Convert tests from Jest to node-test #2728
Convert tests from Jest to node-test #2728MVGRAO wants to merge 5 commits intoopenedx:masterfrom MVGRAO:fix/Test
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @MVGRAO! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Hi @MVGRAO, thanks! Could you please sign the CLA? |
|
Relates to #2725 |
mphilbrick211
moved this from Needs Triage
to Needs Tests Run or CLA Signed
in Contributions
|
@bradenmacdonald @mphilbrick211 I have submitted the form |
|
@mphilbrick211 @bradenmacdonald Can , I know the status |
|
@mphilbrick211 How do we re-trigger the CLA check? @MVGRAO Great, thanks. This is a super busy time for us with the ongoing work for the Ulmo release so it may take me a bit longer to review this. |
|
@bradenmacdonald - I believe re-running the checks will trigger the CLA to run again, and hopefully turn green. If it's not working, let me know. |
|
@bradenmacdonald @mphilbrick211 Was there anything, I can do with CLA |
|
@MVGRAO I'm checking on this for you! Thanks for your patience! |
|
@MVGRAO Can you confirm if you've signed it? Our team checked and it looks like you only viewed it, not signed. |
|
@mphilbrick211 Yes , I have filled , If you want the pdf , Which I have stored in a medium |
Thanks, @MVGRAO let me see if I can get an updated status for you. |
|
@mphilbrick211 Ok , Hope it works |
@MVGRAO please see the following from our legal team: We haven't seen a DocuSign come in yet from him. After he completes the form at the CLA page link, they should also expect to see a DocuSign comes afterwards that they need to sign. If they no longer can access that previous DocuSign link, e.g., the link has expired, please tell them to go ahead and start the process again (complete the CLA form again and then sign the DocuSign). |
|
@mphilbrick211 @bradenmacdonald Kindly check this 
|
Checking on this for you, @MVGRAO! |
|
@mphilbrick211 Yes , It's not turning green not at all |
|
@bradenmacdonald Yes , My commit messages are not matching to your rule set , I have checked the logs CC: @mphilbrick211 |
|
@MVGRAO You will need to rebase the PR. If you do an interactive rebase with the correct options, you will have the opportunity to rename each commit to the correct format as you rebase. When you push the rebased PR, it will also fix the CLA check, if that has been submitted correctly. We are currently exploring a couple options here, so we may decide to use Vitest instead of node:test, but I'd like to explore both options for now. |
|
@bradenmacdonald Yes , Can I move with Vitest Or Node |
@MVGRAO can you rebase? Our legal team is also checking on status for you. |
@MVGRAO our legal team will be reaching out to you with next steps. |
4 participants
Summary of changes
Migration plan added
Added a tracked todo list (via the workspace todo tool) to break the Jest → node:test migration into clear, verifiable steps so we can convert tests incrementally and show progress.
Package scripts for node:test and Windows linting
Added/updated npm scripts in package.json: a test:node example (runs node --test) and Windows-friendly helpers: fix:eol (normalize EOLs) and lint:win (runs stylelint then npx eslint ...) so you can run tests/lint on Windows without POSIX wrapper failures.
TypeScript/ESLint coverage fix
Updated tsconfig.json to include tests//* and scripts//* so the TypeScript ESLint parser (parserOptions.project) covers test and script files.
Added file-level ESLint disable comments to setup-env.ts to avoid setup-file-specific lint failures (dev-dep imports and class-count).
Repository EOL normalization & enforcement
Added .gitattributes to enforce LF for source files and prevent new CRLF commits.
Added normalize-line-endings.js and the npm run fix:eol script to convert CRLF → LF across the repo so ESLint linebreak-style errors are resolved.
Lint-rule compliance / script hardening
Updated the normalizer script to remove continue and replace console.log with process.stdout.write to satisfy ESLint rules (no-continue, no-console).
Converted target test files to LF line endings so npx eslint --fix and npm run lint:win can run with far fewer errors.